SOURCES: apache.init - use $RETVAL,

[Andrzej Krzysztofowicz]

Elan =?iso-8859-1?q?Ruusam=E4e?= wrote:
> On Wednesday 18 May 2005 17:32, Andrzej Krzysztofowicz wrote:
> > glen wrote:
> > > @@ -83,13 +83,13 @@
> > >  	if [ -f /var/lock/subsys/httpd ]; then
> > >  		msg_reloading httpd.${HTTPD_MPM}
> > >  		httpd.${HTTPD_MPM} $CFG -t > /dev/null 2>&1
               ^^^^^^^^^^^^^^^^^^^
You check this code
> > > -		if [ $? -eq 0 ]; then
> > > +		RETVAL=$?
> > > +		if [ $RETVAL -eq 0 ]; then
> > >  		    daemon httpd.${HTTPD_MPM} $CFG -k graceful
                   ^^^^^^^^^^^^
But this is left unchecked.

> >
> > daemon is assumed never to fail ?
> > Even in future ?
> don't understand, you mean error code from daemon isn't checked?
> or something wrong with the change?

I don't know whether and when daemon() return non-zero exit code.
And I'm to lazy to check...

-- 
=======================================================================
  Andrzej M. Krzysztofowicz               ankry at mif.pg.gda.pl
  phone (48)(58) 347 14 61
Faculty of Applied Phys. & Math.,   Gdansk University of Technology