SOURCES: kdebase-startkde.patch - better check

[Elan Ruusamäe]

On Sunday 13 November 2005 23:27, Adam Gorzkiewicz wrote:
> > SOURCES/kdebase-startkde.patch:1.9 ---
> > SOURCES/kdebase-startkde.patch:1.8	Sun Nov 13 21:01:35 2005 ++
> > + SOURCES/kdebase-startkde.patch	Sun Nov 13 21:03:37 2005 @@
> > -4,7 +4,7 @@
> >   # run KPersonalizer before the session, if this is the first login
> >   if test "$kpersonalizerrc_general_firstlogin" = "true"; then
> > -+  if test `/usr/bin/which kpersonalizer 2>/dev/null`; then
> > ++  if [ -x /usr/bin/kpersonalizer ]; then
>
>               ^^^^^^^^^
>
> I think i'ts wrong to hardcode the accurate path here. In this case You
> can't eg. to redefine "%{_prefix}" at build time.
i was more thinking that using `which` it could find outdated kpersonalizer 
which you had manually installed to /usr/local, and it really should use 
kpersonalizer from rpm installation.

i guess need to vote here, which way to go ;)

-- 
glen