SPEC update: rb_libtorrent and qbittorrent

[Elan Ruusamäe]

On Sunday 03 August 2008 19:00:08 Zsolt Udvari wrote:
> Hi all!
>
> There are two spec-update.

qbittorrent.spec:
1. source unpack should be done in %prep, not %build 
2. do not leave in trailing space (adapter spec before diff)
3. use common source0 sourceforge urls (adapter spec before diff)
4. there should be trailing dot in %desc -l hu
5. the asio includes.... hmm, shouldn't there be asio.spec whose -devel are 
used?

rb_bittorrent.spec:
1. if patch0 is outdated, it should be removed from spec not commented out
if it's not updated, there should be left comment why it's not updated. but 
you should rather update patch as functionality flip/flop is not welcome.
2. discard quotes from %setup
3. %configure options should be each on single line (adapter could do it for 
you)
4. never disable rm -rf $RPM_BUILD_ROOT from spec. if you want to do 
shortcircuit or keep files in buildroot, use SPECS/repackage.sh or 
SPECS/compile.sh scripts (and SPECS/md5 is useful too sometimes)
5. do not change verbose %files to globs (libtorrent-13.so -> *)
%ghost symlinks should be packaged too most likely, and *.so should be 
in -devel (unless the package already is broken to use *.so instead of 
*.so.1)
6. disabling sed subst in %prep goes under same rule as #1. leave comment or 
remove it completely (there's cvs annotate / cvs log for historical changes)
7. where the %{_bindir} file dissapeared?

-- 
glen