SOURCES: cmake-ar.patch (NEW) - set ar

[Elan Ruusamäe]

On Friday 15 August 2008 19:00:09 Bartosz Świątek wrote:
> 2008/8/15, Elan Ruusamäe <glen at delfi.ee>:
> > On Friday 15 August 2008 18:37:06 Bartosz Świątek wrote:
> >  > 2008/8/15, Elan Ruusamäe <glen at delfi.ee>:
> >  > > On Friday 15 August 2008 14:40:11 shadzik wrote:
> >  > >  > Author: shadzik                      Date: Fri Aug 15 11:40:11
> >  > >  > 2008 GMT Module: SOURCES                       Tag: HEAD
> >  > >  > ---- Log message:
> >  > >  > - set ar
> >  > > >
> >  > > > -  FIND_PROGRAM(CMAKE_AR NAMES ${_CMAKE_TOOLCHAIN_PREFIX}ar HINTS
> >  > > > ${_CMAKE_TOOLCHAIN_LOCATION})
> >  > > >
> >  > >  > +  SET(CMAKE_AR /usr/bin/ar)
> >  > >
> >  > > doesn't this break --target= builds?
> >  >
> >  > why should it?
> >
> > because you hardcode it to be /usr/bin/ar, but for --target= it could
> > (should) be:
> >
> >  18:49:22 glen[pts/6]@carme-pld rpm/SPECS$ l /usr/bin/*linux*-ar
> >  -rwxr-xr-x 1 root root 504K 2006-08-01 20:37
> > /usr/bin/alpha-pld-linux-ar* -rwxr-xr-x 2 root root 556K 2008-01-14 21:31
> > /usr/bin/arm-linux-gnueabi-ar* -rwxr-xr-x 1 root root 625K 2007-03-19
> > 00:13 /usr/bin/powerpc-pld-linux-ar* -rwxr-xr-x 1 root root 651K
> > 2006-08-02 01:28 /usr/bin/ppc64-pld-linux-ar* -rwxr-xr-x 1 root root 642K
> > 2007-03-17 12:37 /usr/bin/ppc-pld-linux-ar* -rwxr-xr-x 1 root root 517K
> > 2007-06-24 20:03 /usr/bin/sparc64-pld-linux-ar* -rwxr-xr-x 1 root root
> > 512K 2006-08-02 01:39 /usr/bin/sparc-pld-linux-ar*
>
> nope, that's what cmake authors thought too, i guess. And that causes
> cmake not to find ar at all, what breaks almost all builds that
> statically link something. Right now i've been able to build stuff
> using cmake on i686 and x86_64 without any problems.

well, i said my point, dunno who wins here.

and plz do not remove cc: pld-devel-en@!

-- 
glen