rescuecd.spec - problems with sending build request

Kamil Dziedzic kamil.listy at klecza.pl
Tue Mar 18 23:18:43 CET 2008


Dnia wtorek 18 marzec 2008, Patryk Zawadzki napisał:
> Yes, how do you differentiate between query params and parts of
> document name? It's the spec file where encoding should happen (as
> currently it's not a valid URI, I believe FTP schema does not even
> allow one to use query strings).
Why in spec? It is a valid URI.

I don't understand or you;) Could you give me a live example when this will 
not work?

For better undertanding I will try to explain this more verbose. Lets drop for 
now problems with rescuecd.spec (because it has more problems). Lets take for 
example dmg2img.spec.

Logs from test build: http://wklej.org/id/479c5dfff2

I'm saying that builder script is now broken. You can't pass as SourceX urls 
with special characters like for example "? &". Why not? Because when 
distfiles fetches files it makes something like that:
wget -O "download.pl?dmg2img.tar.gz" 
http://vu1tur.eu.org/tools/download.pl?dmg2img.tar.gz

> From logs: 19:46:11 (0.00 B/s) - `download.pl?dmg2img.tar.gz' saved [0]
So it "get" file "download.pl" and saves it as "download.pl?dmg2img.tar.gz" on 
ftp. Now when we want try to build a package from spec then builder script 
tries to download file from 
distfiles. He uses same method like distfiles to get file:
wget -O "download.pl?dmg2img.tar.gz" 
ftp://distfiles.pld-linux.org/distfiles/by-md5/e/3/e3fa1bc5f38e961230100c1c2274bd28/download.pl?dmg2img.tar.gz

> From logs: # No matches on pattern `download.pl?dmg2img.tar.gz'. 
But on ftp there is no file "download.pl", there is a 
file "download.pl%3fdmg2img.tar.gz" 
ftp://distfiles.pld-linux.org/distfiles/by-md5/e/3/e3fa1bc5f38e961230100c1c2274bd28/download.pl%3fdmg2img.tar.gz

So to resolve this problem we should encode url (just 
name - "download.pl?dmg2img.tar.gz") when geting file from distfiles like in 
example above.
-- 
Regards, Kamil Dziedzic
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : /mailman/pipermail/pld-devel-en/attachments/20080318/c86f5bd6/attachment.sig 


More information about the pld-devel-en mailing list