packages: openldap/ldap.init - properly escape url list
Jan Rekorajski
baggins at sith.mimuw.edu.pl
Thu Sep 10 17:21:45 CEST 2009
On Wed, 09 Sep 2009, Elan Ruusamäe wrote:
> On Wednesday 09 September 2009 16:45:10 baggins wrote:
> > ================================================================
> > Index: packages/openldap/ldap.init
> > diff -u packages/openldap/ldap.init:1.32 packages/openldap/ldap.init:1.33
> > --- packages/openldap/ldap.init:1.32 Thu Sep 3 13:18:01 2009
> > +++ packages/openldap/ldap.init Wed Sep 9 15:45:05 2009
> > @@ -52,7 +52,7 @@
> > if [ -n "$SLAPDNICE" ]; then
> > SERVICE_RUN_NICE_LEVEL=$SLAPDNICE
> > fi
> > - daemon /usr/sbin/slapd $ARGS ${SLAPDURLLIST:+ -h "$SLAPDURLLIST"}
> > + daemon /usr/sbin/slapd $ARGS ${SLAPDURLLIST:+ -h \"$SLAPDURLLIST\"}
>
> this is what the fix was about. you assume shell syntax, which is wrong with
> RC_LOGGING=no, likely which is OK for RC_LOGGING=yes
>
> how to make the args compatible for both?
>
> adding eval to start-stop-daemon sounds like asking for more troubles.
>
> conditional on RC_LOGGING In ldap.init script?
>
> and initlog (which takes the shell syntax) should die, yet nobody has done it
> and RC_LOGGING=no has few other incompatabilities (lighttpd reload sometimes
> loses pidfile)
Wasn't it you who introduced start-stop-daemon usage to rc-scripts and
created inconsistency in running daemons? Sorry, but default is
RC_LOGGING=yes and I really don't have the time to implement a workaround.
If you think initlog should die, then go ahead and kill it. Everyone
will be happy.
--
Jan Rekorajski | ALL SUSPECTS ARE GUILTY. PERIOD!
baggins<at>mimuw.edu.pl | OTHERWISE THEY WOULDN'T BE SUSPECTS, WOULD THEY?
BOFH, MANIAC | -- TROOPS by Kevin Rubio
More information about the pld-devel-en
mailing list