[packages/cryptsetup] Providing and obsoleting itself makes no sense Release 2

[Elan Ruusamäe]

On 07.08.2012 12:49, baggins wrote:
> commit f96aa1090f0e787e82918332ea8eb84dc1e98349
> Author: Jan Rękorajski<baggins at pld-linux.org>
> Date:   Tue Aug 7 11:48:50 2012 +0200
>
>      Providing and obsoleting itself makes no sense
>      Release 2
no, this is way to specify proper upgrade path. what makes you think it 
makes no sense!? what is the error that made you touch this at all!?

and double no: it's providing
cryptsetup-luks = 1.5.0

but obsoleting
cryptsetup-luks < 1.4.1-2

these are *not* the same packages

read the changelogs (aka git blame!) next time before killing stuff you 
don't understand

>   cryptsetup.spec | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)
> ---
> diff --git a/cryptsetup.spec b/cryptsetup.spec
> index 90bf85e..3bf6e60 100644
> --- a/cryptsetup.spec
> +++ b/cryptsetup.spec
> @@ -8,7 +8,7 @@ Summary:	LUKS for dm-crypt implemented in cryptsetup
>   Summary(pl.UTF-8):	LUKS dla dm-crypta zaimplementowany w cryptsetup
>   Name:		cryptsetup
>   Version:	1.5.0
> -Release:	1
> +Release:	2
>   License:	GPL v2
>   Group:		Base
>   # Source0Download: http://code.google.com/p/cryptsetup/downloads/list
> @@ -26,8 +26,6 @@ BuildRequires:	libsepol-devel
>   BuildRequires:	libtool>= 2:2.0
>   BuildRequires:	libuuid-devel
>   BuildRequires:	popt-devel>= 1.7
> -Provides:	cryptsetup-luks = %{version}-%{release}
> -Obsoletes:	cryptsetup-luks<  1.4.1-2
>   %if %{with python}
>   BuildRequires:	python-devel>= 1:2.4
>   BuildRequires:	rpm-pythonprov
> @@ -51,8 +49,8 @@ BuildRequires:	udev-static
>   	%endif
>   %endif
>   Requires:	popt>= 1.7
> -Provides:	cryptsetup = %{version}
> -Obsoletes:	cryptsetup
> +Provides:	cryptsetup-luks = %{version}-%{release}
> +Obsoletes:	cryptsetup-luks<  1.4.1-2
>   Conflicts:	udev<  1:118-1
>   Conflicts:	udev-core<  1:115
>   BuildRoot:	%{tmpdir}/%{name}-%{version}-root-%(id -u -n)
> _______________________________________________
> pld-cvs-commit mailing list
> pld-cvs-commit at lists.pld-linux.org
> http://lists.pld-linux.org/mailman/listinfo/pld-cvs-commit


-- 
glen