SVN: geninitrd/trunk/mod-suspend.sh

[Elan Ruusamäe]

On 15/02/12 05:46, Kacper Kornet wrote:
> On Thu, Jan 05, 2012 at 06:07:25PM +0100, glen wrote:
>> Author: glen
>> Date: Thu Jan  5 18:07:24 2012
>> New Revision: 12457
>
>> Modified:
>>     geninitrd/trunk/mod-suspend.sh
>> Log:
>> parse resume= param value into $resume, not just hardcode "yes"
>
>> Modified: geninitrd/trunk/mod-suspend.sh
>> ==============================================================================
>> --- geninitrd/trunk/mod-suspend.sh	(original)
>> +++ geninitrd/trunk/mod-suspend.sh	Thu Jan  5 18:07:24 2012
>> @@ -62,7 +62,7 @@
>>   	resume=no
>>   	for arg in $CMDLINE; do
>>   		if [ "${arg##resume=}" != "${arg}" ]; then
>> -			resume=yes
>> +			resume=${arg##resume=}
>>   		fi
>>   	done
>>   	if [ "$resume" = "yes" ]; then
>
> 1. What is the reason for this change?

parse resume= param value into $resume, not just hardcode "yes"
so you could say "resume=no" from kernel commandline (i.e temporary 
disabling booting with resume by just changing yes to no in grub line edit)

I can't find a place where the variable
>     resume is used.

it cames from kernel commandline (/proc/cmdline) as "resume=yes"

> 2. Assuming it is a valid change, the condition
>
>   if [ "$resume" = "yes" ]; then
>
>     should also be changed.

eek? why?



-- 
glen