[packages/bash-completion] - build fix

[Elan Ruusamäe]

On 18.02.2013 12:50, Arkadiusz Miśkiewicz wrote:
> On Monday 18 of February 2013, Elan Ruusamäe wrote:
>> On 18.02.2013 11:52, Arkadiusz Miśkiewicz wrote:
>>> On Monday 18 of February 2013, Elan Ruusamäe wrote:
>>>> On 17.02.2013 01:20, arekm wrote:
>>>>> commit 0113649bc4feb08040f32c567044c1f9ba942350
>>>>> Author: Arkadiusz Miśkiewicz <arekm at maven.pl>
>>>>> Date:   Sun Feb 17 00:20:13 2013 +0100
>>>>>
>>>>>        - build fix
>>>>>     
>>>>>     bash-completion.spec | 2 +-
>>>>>     1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> ---
>>>>> diff --git a/bash-completion.spec b/bash-completion.spec
>>>>> index 51263e2..bc5a28a 100644
>>>>> --- a/bash-completion.spec
>>>>> +++ b/bash-completion.spec
>>>>> @@ -41,7 +41,7 @@ dopełnianie parametrów linii poleceń.
>>>>>
>>>>>     %prep
>>>>>     %setup -q
>>>>>
>>>>> -cp -p %{SOURCE4} completions/pear
>>>>> +cp -p '%{SOURCE4}' completions/pear
>>>>>
>>>>>     %patch0 -p1
>>>>>     %patch1 -p1
>>>> eee, eek? if the error was because sourcedir contained space, then
>>>> 99.99% of our specs are broken
>>>>
>>>> what was the error?
>>> SOURCE4 name contains & character
>> rpm 5 treats '#' as comment (at least on SourceX lines), you must use
>> different hack here:
> cp -p '%{SOURCE4}' works fine, too for this particular issue I had.
>
basename-rename-hack is more consistent, it keeps the originally 
intended filename, i.e "pear" not name what you got: " 
pear?revision=285425&view=co"

you fixed only shell quoting, but rpmbuild takes filenames by cutting 
out from last slash.

and the basename is also used when fetching from distfiles, currently 
you were lucky as query-string part (?revision=285425&view=co) is 
ignored when fetching from distfiles via ftp.


-- 
glen