[packages/git-core] - hardcode completions path to avoid bash+bash-completion BR

Elan Ruusamäe glen at pld-linux.org
Fri Jun 14 14:46:17 CEST 2013


On 13.06.2013 20:06, qboosh wrote:
> commit 1db8400f5a741a3f3ae86f1a705d8109783dd946
> Author: Jakub Bogusz <qboosh at pld-linux.org>
> Date:   Thu Jun 13 19:06:48 2013 +0200
>
>      - hardcode completions path to avoid bash+bash-completion BR
>
>   git-core.spec | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> ---
> diff --git a/git-core.spec b/git-core.spec
> index 4080c8f..1c71b07 100644
> --- a/git-core.spec
> +++ b/git-core.spec
> @@ -30,7 +30,6 @@ Patch3:		cherry-picked-commitlog.patch
>   URL:		http://git-scm.com/
>   BuildRequires:	autoconf >= 2.59
>   BuildRequires:	automake
> -BuildRequires:	bash-completion >= 2.0
>   BuildRequires:	curl-devel
>   BuildRequires:	expat-devel
>   BuildRequires:	gettext-devel
> @@ -79,7 +78,7 @@ BuildRoot:	%{tmpdir}/%{name}-%{version}-root-%(id -u -n)
>   %define		webappdir	%{_sysconfdir}/webapps/%{webapp}
>   %define		appdir		%{_datadir}/%{webapp}
>   %define		cgibindir	%{_prefix}/lib/cgi-bin
> -%define		bash_compdir	%(pkg-config --variable completionsdir bash-completion || echo /etc/bash_completion.d)
> +%define		bash_compdir	%{_datadir}/bash-completion/completions
>
why is hardcoding good?

-- 
glen



More information about the pld-devel-en mailing list