[packages/openssh/GIT_-nopass] don't pass and accept GIT_ variables

Kacper Kornet draenog at pld-linux.org
Tue Oct 15 00:01:19 CEST 2013


On Mon, Oct 14, 2013 at 11:56:37PM +0200, Kacper Kornet wrote:
> commit 289a902d894a2dc8d78d5e4a762568132f3c8108
> Author: Kacper Kornet <draenog at pld-linux.org>
> Date:   Mon Oct 14 22:52:22 2013 +0100

>     don't pass and accept GIT_ variables

>     Passing GIT_* variables can break some packages. For example gitolite
>     (see gitolite-env.patch) and gitolite3.

Unless someone is against I'm going to merge it to master. On the other
hand I don't want to break someone's setups, so if you depend on this
feature it is a chance to protest.


>  openssh-config.patch | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> ---
> diff --git a/openssh-config.patch b/openssh-config.patch
> index e124f10..5bd317b 100644
> --- a/openssh-config.patch
> +++ b/openssh-config.patch
> @@ -50,8 +50,8 @@
>   # no default banner path
>   #Banner /some/path

> -+# Accept locale-related environment variables, also accept GIT vars
> -+AcceptEnv LANG LC_* LANGUAGE TZ GIT_*
> ++# Accept locale-related environment variables
> ++AcceptEnv LANG LC_* LANGUAGE TZ
>  +
>   # override default of no subsystems
>   Subsystem	sftp	/usr/libexec/sftp-server
> @@ -92,6 +92,6 @@
>  +	ServerAliveInterval 60
>  +	ServerAliveCountMax 10
>  +	TCPKeepAlive no
> -+# Send locale-related environment variables, also pass GIT vars
> -+	SendEnv LANG LC_* LANGUAGE TZ GIT_*
> ++# Send locale-related environment variables
> ++	SendEnv LANG LC_* LANGUAGE TZ
>  +	HashKnownHosts yes
> ================================================================

> ---- gitweb:

> http://git.pld-linux.org/gitweb.cgi/packages/openssh.git/commitdiff/289a902d894a2dc8d78d5e4a762568132f3c8108

> _______________________________________________
> pld-cvs-commit mailing list
> pld-cvs-commit at lists.pld-linux.org
> http://lists.pld-linux.org/mailman/listinfo/pld-cvs-commit

-- 
  Kacper Kornet


More information about the pld-devel-en mailing list