[packages/rpm] use correct string returned by file for Perl scripts

Kacper Kornet draenog at pld-linux.org
Tue Oct 7 18:33:55 CEST 2014


On Tue, Oct 07, 2014 at 06:22:54PM +0200, Jakub Bogusz wrote:
> On Tue, Oct 07, 2014 at 05:59:44PM +0200, draenog wrote:
> > +--- lib/rpmfc.c.orig	2014-10-07 15:53:03.185631053 +0100
> > ++++ lib/rpmfc.c	2014-10-07 16:02:32.487591097 +0100
> > +@@ -593,7 +593,7 @@
> > + 
> > +   { "Desktop Entry",		RPMFC_DESKTOP_FILE|RPMFC_INCLUDE },
> > + 
> > +-  { "perl script text",		RPMFC_PERL|RPMFC_INCLUDE },
> > ++  { "Perl script",		RPMFC_PERL|RPMFC_INCLUDE },
> > +   { "Perl5 module source text", RPMFC_PERL|RPMFC_MODULE|RPMFC_INCLUDE },
> > + 
> > +   { "PHP script text",		RPMFC_PHP|RPMFC_INCLUDE },

> I think it depends on file/magic version.
> IMO it's better to include both strings.

Indeed, on Ac file-4.23 it returns the old string. I haven't dig
deep enough in file history previously. Fixed in next commit. 
 
-- 
  Kacper


More information about the pld-devel-en mailing list