[packages/sqlite3] drop pointless year macro

Adam Osuchowski adwol at zonk.pl
Sat Feb 28 23:30:10 CET 2015


glen wrote:
> commit 9ff1c54dc27e48a465cfd09860bd031e6923c26a
> Author: Elan Ruusamäe <glen at delfi.ee>
> Date:   Thu Feb 26 22:08:01 2015 +0200
> 
>     drop pointless year macro
> 
>  sqlite3.spec | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> ---
> diff --git a/sqlite3.spec b/sqlite3.spec
> index 0e3842c..63fe775 100644
> --- a/sqlite3.spec
> +++ b/sqlite3.spec
> @@ -20,12 +20,9 @@
>  %undefine	with_tests
>  %endif
>  
> -%define		version_year	2015
>  #define		version_num %(echo %{version} |  awk -F. '{printf("%d%02d%02d%02d", $1, $2, $3, $4)}')
>  %define		version_num	3080803
> -%define		_ulibdir	/usr/lib
>  %define		tclver		8.6


No, it isn't pointless! The values of url and other tags should be universal
as much as possible. In case of version updating, the year in url may change
and nobody wants to wonder if any part of any tag should be updated in
connection with it. Macros is designed for such cases and clearly points
what should to pay attention to.

If %version_year is pointless, the %version_num is pointless too and should
be removed alike. Please keep coherent.

Think logically about changes you apply before you do it and don't
determine and change anything basing on your private judgements and point
of view only. Your are not the one-man oracle! Once again, your behaviour,
manners and collaborative skills leave a lot to be desired.


More information about the pld-devel-en mailing list