[packages/firefox] filterout -Werror=format-security to fix build with gcc7

[Jan Palus]

On 27.08.2017 17:39, Arkadiusz Miśkiewicz wrote:
>On Saturday 26 of August 2017, atler wrote:
>> commit a132acc2832bf9003b9693a696c0cb6d96e44a5e
>> Author: Jan Palus <atler at pld-linux.org>
>> Date:   Sat Aug 26 22:25:55 2017 +0200
>>
>>     filterout -Werror=format-security to fix build with gcc7
>
>Why not fix these errors instead?

If it was an issue with format I would fix it, but it's a problem with option 
parsing semantics in gcc:

$ gcc -Wformat -Werror=format-security -Wno-format test.c
$ rpm -q gcc
gcc-6.4.0-1.x86_64

$ gcc -Wformat -Werror=format-security -Wno-format test.c
cc1: error: -Wformat-security ignored without -Wformat [-Werror=format-security]
cc1: some warnings being treated as errors
$ rpm -q gcc
gcc-7.2.0-1.x86_64

Apparently firefox is quite selective about passing -Wno-format as most files 
are compiled without it. I prefer to wait until either gcc or firefox steps up 
and fixes it on their side.