Jan Rękorajski baggins at pld-linux.org
Fri Jan 5 11:07:50 CET 2018

On Thu, 04 Jan 2018, Patryk Szczygłowski wrote:

> Hi,
> created wireguard.spec. Please someone add this to git, because I have no
> permission to create new packages.

Thanks, done, just a few notes and fixes I did:

- this is not Debian, we do not lowercase everything, we follow upstream
  naming. Thus submitted this as WireGuard
- kernel packages names shoud follow DIR-MODULE naming scheme, here it's
- you added a stub 'tools' package with no files in it, I removed it and
  made main package contain tools
- try to avoid using wildcards in 'files', wildcards could hide
  permission errors and packging problems
- I'm surprised this worked: "setup -n WireGuard-%{version}/src", please
  don't do hacks like that, cd into directories in build and install.

It's also a good idea to run new specs through adapter script (in
adapter package) to catch formatting and common spec problems.

Jan Rękorajski                    | PLD/Linux
SysAdm | baggins<at>pld-linux.org | http://www.pld-linux.org/

More information about the pld-devel-en mailing list