[packages/linux-pstore] - initial

[Arkadiusz Miśkiewicz]

On 21/02/2019 16:38, glen wrote:
> On 2/21/19 3:03 PM, arekm wrote:
> 
>> +%post
>> +if [ -d /sys/fs/pstore ]; then
>> +    grep -qE "^none.*/sys/fs/pstore" %{_sysconfdir}/fstab || (echo -e
>> "none\t\t/sys/fs/pstore\tpstore\tdefaults\t 0 0" >>
>> %{_sysconfdir}/fstab && grep -q "/sys/fs/pstore" /proc/self/mounts ||
>> mount /sys/fs/pstore)
>> +    exit 0
>> +fi
>> +
> 
> 
> yuks.
> 
> 
> i think this should go to "setup" package like rest of the fstab mounts
> 
> 
> and mounting from %post does not seem good either.
> 
> 
> so i propose:
> 
> 1. add to setup the mount with noauto

It is there but as auto

https://git.pld-linux.org/gitweb.cgi?p=projects/setup.git;a=commitdiff;h=7ee07b3cca899e6220914022676f2aab1efb46d9

(need to put it into actual setup.spec, too)

> 
> 2. update rc-scripts to mount it
> 
> 
> this is the way afaik other fs are done.


Initially I added mounting to python script itself. And I guess I go
that route (mount if not mounted) instead of %post.


-- 
Arkadiusz Miśkiewicz, arekm / ( maven.pl | pld-linux.org )