[packages/kernel] - drop unneeded excludes (rpm 4.16 handles these differently from rpm 5)

Arkadiusz Miśkiewicz arekm at maven.pl
Fri Dec 18 19:35:25 CET 2020


W dniu 18.12.2020 o 19:25, Jan Rękorajski pisze:
> On Wed, 16 Dec 2020, Arkadiusz Miśkiewicz via pld-devel-en wrote:
> 
>> W dniu 16.12.2020 o 10:36, Arkadiusz Miśkiewicz pisze:
>>> W dniu 16.12.2020 o 10:14, Elan Ruusamäe pisze:
>>>> On 15.12.2020 18:05, arekm wrote:
>>>>
>>>>>   %exclude %{_kernelsrcdir}/scripts/mod
>>>>> -%exclude %{_kernelsrcdir}/scripts/module-common.lds
>>>>
>>>> what do you mean?
>>>>
>>>> rpm 4.16 does prefix match and rpm5 does glob match?
>>>>
>>>> ie that
>>>>
>>>> %{_kernelsrcdir}/scripts/mod
>>>>
>>>>   matches also
>>>>
>>>> %{_kernelsrcdir}/scripts/module-common.lds
>>>>
>>>>   on 4.16?
>>>>
>>>>
>>>> does your change make .spec inclusive to 4.16-only now?
>>>
>>> %exclude non-existsing-file seems to pass on 4.16 while fail on 5.
>>>
>>>
>>> Similar thing - %doc with not existing file succeeds on 4.16.
>>>
>>
>> Another one. Non existing %ghost also doesn't cause build failure and
>> results in unpackaged files (if soname gets new version while spec has
>> old one as ghost).
> 
> I tested %doc and %exclude and both fail build when passed non-existing
> file:
> 
> RPM build errors:
>     Could not canonicalize hostname: pldmachine
>     File not found: /home/users/baggins/tmp/alien-8.95.1-x86_64-root-baggins/asdfgsdgsdfgsadfg
>     File not found: /home/users/baggins/tmp/alien-8.95.1-x86_64-root-baggins/usr/share/doc/alien-8.95.1/fubar
> 
> %ghost does pass tho.
> 
> $ rpm -q rpm
> rpm-4.16.0-0.10.x86_64
> 

Try this:

-%doc debian/changelog README TODO
+%doc {debian/changelog,README,TODO,NOTEXISTENT}

-- 
Arkadiusz Miśkiewicz, arekm / ( maven.pl | pld-linux.org )


More information about the pld-devel-en mailing list