[projects/pld-builder.new] Drop a TODO for rpm4 migration

Elan Ruusamäe glen at pld-linux.org
Wed Jan 20 13:39:50 CET 2021


On 20.01.2021 01:35, baggins wrote:

> +        # TODO: detect rpm version and use the below for rpm 4.x
> +        # rpmcommand = "rpmbuild --nobuild -br"

we should have some maintainable version for detecting this. perhaps add 
some macro?

- %{?rpm4}

- %{!?rpm5}


or a file?:

- test -f /usr/lib/rpm/some-specifically-identified-file


as can seen, it's not easy to get right:

1. by baggins: 
https://github.com/pld-linux/rpm-build-tools/commit/ac1281919568d928bdefe8cbc5436cdf3fa5906d

2. fixing baggins by glen: 
https://github.com/pld-linux/rpm-build-tools/commit/e267517f208dae6ee42da97e4380b9735a8b65bf

3. fixing glen by jpaulus: 
https://github.com/pld-linux/rpm-build-tools/commit/30e78ca0b942bf5e64e1418d9f2f29129854bafd


also, i think we may need to have 3 flavours:

1. rpm 5

2. rpm 4.5

3. rpm 4.16+



More information about the pld-devel-en mailing list