wireguard.spec
Patryk Szczygłowski
patryk at patryk.net
Sat Jan 6 15:03:39 CET 2018
Thanks Jan, I don't create new packages often so that might be the reason
behind few mistakes.
Cheers.
2018-01-05 10:07 GMT+00:00 Jan Rękorajski <baggins at pld-linux.org>:
> On Thu, 04 Jan 2018, Patryk Szczygłowski wrote:
>
> > Hi,
> >
> > created wireguard.spec. Please someone add this to git, because I have no
> > permission to create new packages.
>
> Thanks, done, just a few notes and fixes I did:
>
> - this is not Debian, we do not lowercase everything, we follow upstream
> naming. Thus submitted this as WireGuard
> - kernel packages names shoud follow DIR-MODULE naming scheme, here it's
> kernel-misc-wireguard
> - you added a stub 'tools' package with no files in it, I removed it and
> made main package contain tools
> - try to avoid using wildcards in 'files', wildcards could hide
> permission errors and packging problems
> - I'm surprised this worked: "setup -n WireGuard-%{version}/src", please
> don't do hacks like that, cd into directories in build and install.
>
> It's also a good idea to run new specs through adapter script (in
> adapter package) to catch formatting and common spec problems.
>
> --
> Jan Rękorajski | PLD/Linux
> SysAdm | baggins<at>pld-linux.org | http://www.pld-linux.org/
> _______________________________________________
> pld-devel-en mailing list
> pld-devel-en at lists.pld-linux.org
> http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
>
--
Patryk Szczygłowski
More information about the pld-devel-pl
mailing list