SPECS: qt4.spec - adapter

[Radoslaw Zielinski]

Rafał Cygnarowski <zswi at pers.pl> [21-06-2007 10:14]:
> Dnia środa, 20 czerwca 2007, glen napisał:
[...]
>>  %files -n QtCore-devel -f QtCore-devel.files
>> +%defattr(644,root,root,755)
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> This change is wrong.

Why do you think so?

> Qt*-devel.files already contains this and it's 
> respected. If this is done by adapter, then adapter needs to be fixed.
> Remove these lines, please.

All %files sections should begin with %defattr; no exceptions.  This
cuts down the time needed to wonder if it's needed here and just missing
or defined somewhere else...  Consider it a policy.  Benefit: less bugs,
saved time.

-- 
Radosław Zieliński <radek at pld-linux.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : /mailman/pipermail/pld-devel-en/attachments/20070621/3b192394/attachment.sig