SPECS: qt4.spec - adapter

[Elan Ruusamäe]

On Thursday 21 June 2007, Radoslaw Zielinski wrote:
> Rafał Cygnarowski <zswi at pers.pl> [21-06-2007 10:14]:
> > Dnia środa, 20 czerwca 2007, glen napisał:
>
> [...]
>
> >>  %files -n QtCore-devel -f QtCore-devel.files
> >> +%defattr(644,root,root,755)
> >
> > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > This change is wrong.
>
> Why do you think so?
>
> > Qt*-devel.files already contains this and it's
> > respected. If this is done by adapter, then adapter needs to be fixed.
> > Remove these lines, please.
>
> All %files sections should begin with %defattr; no exceptions.  This
> cuts down the time needed to wonder if it's needed here and just missing
> or defined somewhere else...  Consider it a policy.  Benefit: less bugs,
> saved time.

agree (that's why i commited it too), and it made branch diffing easier of 
both branches in comparision are adaptered.

the same topic can be argued around any *-i18n* *-i10l* packages.

and extra note: it doesn't break anything, the %defattr from -f overrides it 
anyway.

-- 
glen