packages: gdk-pixbuf2/gdk-pixbuf2.spec - +x libpixbufloader-*.so, - removed...

Tomasz Pala gotar at polanet.pl
Mon Nov 15 14:02:21 CET 2010


On Mon, Nov 15, 2010 at 07:14:26 +0100, Jakub Bogusz wrote:

>> >> -%{!?with_apidocs:%{__rm} -rf $RPM_BUILD_ROOT%{_gtkdocdir}}
                                  ^ removed this one too
>> >> +%{!?with_apidocs:rm -rf $RPM_BUILD_ROOT%{_gtkdocdir}}
>> > 
>> > %{__rm} is intentional here.
> 
> We don't want to keep hundreds of obsolete rms - nobody checks such
> commands on upgrade unless build fails.

OK, so I've brought it back and additionally:
%prep	%{__rm} po/io.po

>> And if we want so - why not plain rm without -f?
> 
> %{__rm} is defined as "rm --interactive=never".

OK, this is the first PLD spec file I've seen using __rm macro. And I
see it's over 21 months old now, this should go into some guideline.

-- 
Tomasz Pala <gotar at pld-linux.org>


More information about the pld-devel-en mailing list