builder md5 for nosource broken

[Elan Ruusamäe]

On 06.09.2011 14:00, Elan Ruusamäe wrote:
> considering such spec:
>
> Source0:    http://somewhere/%{version}.tar.gz
> # NoSource0-md5:  9623ae8125382e7076818743d4dfac20
> NoSource:   0
>
> you invoke:
> $ ./builder -5 PKG.spec
>
> and that is transformed into:
> Source0:    http://somewhere/%{version}.tar.gz
> # NoSourceSource0-md5:  9623ae8125382e7076818743d4dfac20
> NoSource:   0
>
> note the "NoSourceSource" part which should stay like original .spec was
>
> builder rev: 1.651
>
> $ rpm -qf /bin/ksh
> mksh-40b-1.x86_64
>

problematic is patch-md5 commit:

http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/packages/builder?r1=1.648#rev1.648
http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/packages/builder.diff?r1=1.647;r2=1.648;f=h

here's reproducer:

$ ./builder -g test -r builder
$ cd builder

ok with 1.647:

$ (cd ..; cvs up -r 1.647 builder)
$ ./builder -Tv test.spec -r builder
# $Revision: 1.16.4.66.2.1.2.7.2.20.4.2 $, $Date: 2011/10/28 09:56:22 $
WARNING! Spec name (test) does not agree with package name (builder)
Version: 1
Release: 0.1
CVS tag: builder-1-0_1

broken with 1.648:
$ (cd ..; cvs up -r 1.648 builder)
$ ./builder -Tv test.spec -r builder
# $Revision: 1.16.4.66.2.1.2.7.2.20.4.2 $, $Date: 2011/10/28 09:56:22 $
WARNING! Spec name (test) does not agree with package name (builder)
Version: 1
Release: 0.1
CVS tag: builder-1-0_1
Tagging 1 files
cvs server: nothing known about configmanager-1.zip
cvs [server aborted]: correct the above errors first!



-- 
glen