[projects/template-specs] - stop including perl macros, it's not needed, rpm does this on its own

Jakub Bogusz qboosh at pld-linux.org
Sun Jan 26 21:16:46 CET 2020


On Sun, Jan 26, 2020 at 06:55:19PM +0100, Jan Rękorajski wrote:
> On Sun, 26 Jan 2020, Jakub Bogusz wrote:
> 
> > On Sat, Jan 25, 2020 at 02:06:07PM +0100, baggins wrote:
> > > commit f75adea6b3f6c1343989e98a27167605ed55b780
> > > Author: Jan Rękorajski <baggins at pld-linux.org>
> > > Date:   Sat Jan 25 14:03:53 2020 +0100
> > > 
> > >     - stop including perl macros, it's not needed, rpm does this on its own
> > 
> > I wonder how to specify dependency on rpm(-build) which includes
> > perl/php/* macros now.
> > 
> > Currently building e.g. perl-* module with 1 month old rpm succeeds, but results
> > in missing perl() reqs/provs.
> 
> Only if you don't have rpm-*perlprov package. And it still wouldn't work
> even if you had that include, since it's just a bunch of macros from
> rpm-build package. Macros, that have been loaded automagically since $YEARS.

Oh, I was wrong about the way it works.

The perl/etc. macro files were indeed included, but until recent changes
%__perl_{provides,requires} macros were redefined to %{nil} in macros.build.
Then manual inclusion of macros.perl etc. in .spec redefined %__perl_{provides,requires}
macros again to proper scripts.

After these commits:
e821f14cac60b7f9bf62abcbb848e114a92abc2f
cdc9189ebe27f76cf935f813eb75c89ec246604f
%__{perl,php,mono}_{provides,requires} macros are always defined to point to
actual scripts, so the manual inclusion of macros.{mono,perl,php} in specs is
obsolete since cdc9189ebe27f76cf935f813eb75c89ec246604f, first packaged as
rpm-pld-macros-build-1.744-3.

So it looks like after removal of manual provides the rpmbuild(macros) dependency
should be bumped to 1.745 (after version bump in rpm-pld-macros).


(if I haven't missed something... after "solving" 4 boxes of Ikea
puzzles I'm a bit tired)

-- 
Jakub Bogusz    http://qboosh.pl/


More information about the pld-devel-en mailing list